github-url-detection icon indicating copy to clipboard operation
github-url-detection copied to clipboard

Include wiki diffs in `hasCode`

Open fregante opened this issue 4 years ago • 3 comments

Example:

https://github.com/pixiebrix/pixiebrix-extension/wiki/Web-Extensions-behaviors/_compare/664a8f7^...664a8f7

There might be more URLs.

fregante avatar Aug 06 '21 21:08 fregante

Source files diffs should probably be included too, e.g.:

https://togithub.com/fregante/github-url-detection/edit/main/index.ts

The thing is, there's not really any "code elements" on the page until you make an edit and click on the "Preview" tab.

cheap-glitch avatar Dec 18 '21 13:12 cheap-glitch

Nah that's a bit much. To target previews we have to add specific listeners and I don't really want to add selection-observer there too 😬

fregante avatar Dec 18 '21 15:12 fregante

Nah that's a bit much. To target previews we have to add specific listeners and I don't really want to add selection-observer there too :grimacing:

It could still be useful to include those URLs for some CSS-only features, e.g. hide-diff-signs. But I guess this should be done in the feature-specific code then.

cheap-glitch avatar Dec 18 '21 15:12 cheap-glitch