Refael Ackermann

Results 90 comments of Refael Ackermann

Hello all I'm dipping my toe in the codebase and thought this might be a nice and small first PR. Do I need to add a line in the changelog...

Since this takes 60% time from current `master` IMHO we can drop the `[System.Text.Json.JsonDocument]` shenanigans

anecdotal pref (3 buckets - main, extras, versions): ``` PS C:\bin\tools\scoop\apps\scoop\current> timeit {scoop search proton} Results from local buckets... 00:00:02.1110227 Name Version Source Binaries ---- ------- ------ -------- proton-mail-export 1.0.4...

Hay @coderabbitai can you take a look?

# Checking for worse cases: ## query that should have many hits: ### base ```shell > Measure-Command -Expression {s search po} Results from local buckets... Milliseconds : 760 Ticks :...

I always feel better when my PR delete more lines then they change/add, but that's me. My assumption was that since the code now only JSON-parses a small subset of...

For posterity, the new assign syntax is: ```html if ("undefined" === typeof nbc) {var nbc = {};}; Object.assign(nbc, {"brand":"nbc",... ```

> Thanks for the report. Is there a thread about the work on closures in `cpdef`... I would like to help (I almost have a M.Sc. in CompSci specializing in...

It just came to me that this might have been a design decision as: ```python a = {'A': 1} b: dict[int | None, str] = {1: 'א'} k1 = a.get('A')...

> `dict.get` has seen a lot of efforts to change things: I assumed so, but still somewhere there is an incongruency since: ```python a = {'A': 1} b = {1:...