redpanda icon indicating copy to clipboard operation
redpanda copied to clipboard

cloud_storage: interrupt downloading segment

Open LenaAn opened this issue 3 years ago • 2 comments

Cover letter

cloud_storage::remote may download a big segment and redpanda will not be stopped until the segment is fully downloaded. This commit adds an abort source that is passed to the offset_translator. partition_recovery_manager may interrupt segment download with this abort source.

Backport Required

  • [ ] not a bug fix
  • [ ] papercut/not impactful enough to backport
  • [x] v22.2.x
  • [x] v22.1.x
  • [x] v21.11.x

UX changes

Describe in plain language how this PR affects an end-user. What topic flags, configuration flags, command line flags, deprecation policies etc are added/changed.

Release notes

  • none

LenaAn avatar Aug 04 '22 17:08 LenaAn

Please clean up not needed includes. Also would be great to add a test where we drop all packets going out to minio and stop redpanda during this period.

mmaslankaprv avatar Aug 08 '22 11:08 mmaslankaprv

Please clean up not needed includes. Also would be great to add a test where we drop all packets going out to minio and stop redpanda during this period.

it doesn't stop just yet, will investigate further why

UPD: it should stop after https://github.com/redpanda-data/redpanda/pull/5905

LenaAn avatar Aug 08 '22 17:08 LenaAn

Waiting until we cut 22.2.x to merge this

LenaAn avatar Aug 10 '22 15:08 LenaAn

CI failure is https://github.com/redpanda-data/redpanda/issues/5079

LenaAn avatar Aug 10 '22 15:08 LenaAn

CI failure is https://github.com/redpanda-data/redpanda/issues/5358

LenaAn avatar Aug 11 '22 11:08 LenaAn

/backport v21.11.x

LenaAn avatar Aug 11 '22 11:08 LenaAn

Failed to run cherry-pick command. I executed the below command:

git cherry-pick -x af30270f16604ec0b90d3ba497edea94b6110456

Workflow run logs.

vbotbuildovich avatar Aug 11 '22 11:08 vbotbuildovich

/backport v22.1.x

LenaAn avatar Aug 11 '22 11:08 LenaAn

Failed to run cherry-pick command. I executed the below command:

git cherry-pick -x af30270f16604ec0b90d3ba497edea94b6110456

Workflow run logs.

vbotbuildovich avatar Aug 11 '22 11:08 vbotbuildovich

will backport to 22.2 after we publish release

LenaAn avatar Aug 11 '22 14:08 LenaAn