redpanda icon indicating copy to clipboard operation
redpanda copied to clipboard
verified publisher icon redpanda-data

tests/docker: update golang to 1.18

Open NyaliaLui opened this issue 3 years ago • 5 comments

Otherwise test build fails with go mod tidy: indicates go 1.18, but maximum supported version is 1.17

NyaliaLui avatar May 26 '22 17:05 NyaliaLui

I'll wait for CI to finish

NyaliaLui avatar May 26 '22 17:05 NyaliaLui

there are other places where go is referenced. should those be updated as well?

  • https://github.com/redpanda-data/vtools/blob/98e27db6204c5fe6c90b287a8ae48a7823247426/taskfiles/dev.yml#L4
  • https://github.com/redpanda-data/redpanda/blob/570063a7754df00758dc66440968cd6459601d93/src/go/k8s/Dockerfile.in#L9

ivotron avatar Aug 10 '22 23:08 ivotron

there are other places where go is referenced. should those be updated as well?

  • https://github.com/redpanda-data/vtools/blob/98e27db6204c5fe6c90b287a8ae48a7823247426/taskfiles/dev.yml#L4
  • https://github.com/redpanda-data/redpanda/blob/570063a7754df00758dc66440968cd6459601d93/src/go/k8s/Dockerfile.in#L9

I see no reason why not.

Also, there is go 1.18.5 - each release since 1.18.2 are security releases.

BenPope avatar Aug 11 '22 01:08 BenPope

to streamline number of reviewers, i've removed @nk-87 and @gousteris and left myself, but feel free to review if you really want

andrewhsu avatar Sep 16 '22 19:09 andrewhsu

@NyaliaLui this PR needs a rebase with latest code on dev to resolve merge conflict

andrewhsu avatar Sep 16 '22 19:09 andrewhsu

Closing this PR because PR #6791 merged which makes this one unnecessary

andrewhsu avatar Oct 29 '22 00:10 andrewhsu