CORE-2742 post review updates
Updates from post review comments in #17616
Backports Required
- [X] none - not a bug fix
- [ ] none - this is a backport
- [ ] none - issue does not exist in previous branches
- [ ] none - papercut/not impactful enough to backport
- [ ] v24.1.x
- [ ] v23.3.x
- [ ] v23.2.x
Release Notes
- none
new failures in https://buildkite.com/redpanda/redpanda/builds/48573#018f35c8-721a-4772-91b9-d6ec57982824:
"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"
new failures in https://buildkite.com/redpanda/redpanda/builds/48573#018f35c8-721d-44d4-a9ae-29998cdc69c3:
"rptest.tests.upgrade_test.UpgradeFromPriorFeatureVersionCloudStorageTest.test_rolling_upgrade.cloud_storage_type=CloudStorageType.S3"
new failures in https://buildkite.com/redpanda/redpanda/builds/48573#018f35d0-78a8-44f3-b504-cfcfba3e80bd:
"rptest.tests.read_replica_e2e_test.ReadReplicasUpgradeTest.test_upgrades.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_cross_shard.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"
"rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=2.cloud_storage_type=CloudStorageType.S3"
new failures in https://buildkite.com/redpanda/redpanda/builds/48573#018f35d0-78b0-47a7-9703-a2c435fffaf9:
"rptest.tests.upgrade_test.UpgradeFromPriorFeatureVersionCloudStorageTest.test_rolling_upgrade.cloud_storage_type=CloudStorageType.S3"
new failures in https://buildkite.com/redpanda/redpanda/builds/48763#018f50fe-65c7-4706-a2f2-1f6869b985aa:
"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"
new failures in https://buildkite.com/redpanda/redpanda/builds/48763#018f50fe-65c5-48aa-9df4-8da98238fe27:
"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"
new failures in https://buildkite.com/redpanda/redpanda/builds/48763#018f5106-34f6-4206-afe3-9ceb73198c9e:
"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.S3"
new failures in https://buildkite.com/redpanda/redpanda/builds/48763#018f5106-34f3-4cc7-b57c-785af571f118:
"rptest.tests.e2e_shadow_indexing_test.EndToEndThrottlingTest.test_throttling.cloud_storage_type=CloudStorageType.ABS"
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48573#018f35d0-78a8-44f3-b504-cfcfba3e80bd
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48573#018f35d0-78ac-4e0a-b675-f034e0c7c998
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/48763#018f50fe-65c7-4706-a2f2-1f6869b985aa
/ci-repeat 1
CI Issues:
- https://github.com/redpanda-data/redpanda/issues/14139
- https://github.com/redpanda-data/redpanda/issues/13275
- https://github.com/redpanda-data/redpanda/issues/18227