node-redis icon indicating copy to clipboard operation
node-redis copied to clipboard

duplicate() is missing on RedisSentinelType

Open CSenshi opened this issue 3 months ago • 2 comments

Description

RedisClientType and RedisClusterType both have .duplicate() method. Should RedisSentinelType not implement this?

Node.js Version

No response

Redis Server Version

No response

Node Redis Version

No response

Platform

No response

Logs


CSenshi avatar Oct 21 '25 14:10 CSenshi

@CSenshi thanks for raising this! On first glance I dont see any reason why not to have the duplicate method. In my eyes this is a low priority though. Not sure when I will have time to look at it

nkaradzhov avatar Oct 22 '25 08:10 nkaradzhov

I think having parity between the base client and sentinel client is a huge devex win, especially for those migrating to sentinel. Considering how similar a single leader vs leader + replica(s) setup is, sentinel could largely be a drop-in replacement from a client perspective, of course with caveats in case of failures.

@nkaradzhov do you mind taking a look if I open a PR for this?

elimelt avatar Nov 25 '25 18:11 elimelt