lettuce icon indicating copy to clipboard operation
lettuce copied to clipboard

Implement nonatomic option for MGET and MSET

Open damonLL opened this issue 3 years ago • 2 comments

Similar to redis-py, can a nonatomic version of MSET and MGET be implemented in Lettuce? Testing 5 keys with mget on Lettuce took about 20-40ms, whereas the same test on redispy with mget nonatomic took 1.2ms.

damonLL avatar Apr 17 '23 16:04 damonLL

What is nonatomic? Do you have a pointer as the command documentation for MSET/MGET doesn't provide any further details.

mp911de avatar Apr 18 '23 07:04 mp911de

Does this help?

https://github.com/redis/redis-py/blob/9f503578d1ffed20d63e8023bcd8a7dccd15ecc5/redis/commands/cluster.py#L154

damonLL avatar Jul 06 '23 20:07 damonLL

Does this help?

https://github.com/redis/redis-py/blob/9f503578d1ffed20d63e8023bcd8a7dccd15ecc5/redis/commands/cluster.py#L154

I am personally not sure what is required here. Lettuce already splits the commands per slot and executes multiple MGET / MSET commands. What can we do better?

tishun avatar Feb 14 '25 15:02 tishun

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 2 weeks this issue will be closed.

github-actions[bot] avatar Mar 17 '25 00:03 github-actions[bot]