yaml-language-server icon indicating copy to clipboard operation
yaml-language-server copied to clipboard

GitlabCI Support

Open CelianR opened this issue 1 year ago • 3 comments

What issues does this PR fix or reference?

This references the GitlabCI Support issue : https://github.com/redhat-developer/yaml-language-server/issues/972

Is it tested? How?

Tested on VsCode (vscode-yaml extension)

Details

Changelog

  • Added gitlabci.enabled / gitlabci.codelensEnabled option
  • !reference tags are not unknown if gitlabci.enabled option
  • Go-to definition for:
    • extends nodes
    • !reference tags (recursive: multiple definitions will be found if a job extends a job extending another job)
    • needs tags
    • include nodes
  • Show job hierarchy with mouse hover
  • All files within all workspaces are parsed (for cross file references)
  • “Show usages” code lens (with gitlabci.codelensEnabled option) which go to references to each job (used within needs and extends)

Screenshots

Screenshot 2024-05-23 at 13 08 52

Go to includes (ctrl click on vscode)

Screenshot 2024-05-23 at 13 09 15

Screenshot 2024-05-23 at 13 09 27

Show / go to definitions for needs / !reference (ctrl hover / ctrl click on vscode)

Screenshot 2024-05-23 at 13 09 45

Show job hierarchy with mouse hover

Screenshot 2024-05-23 at 13 09 56

Screenshot 2024-05-23 at 13 10 16

Show / go to definitions with extends (shows the recursive hierarchy)

Screenshot 2024-05-23 at 13 10 31

Show usages code lens (when clicked)

CelianR avatar May 23 '24 14:05 CelianR

This would be suuuuper useful !

amenasria avatar May 23 '24 14:05 amenasria

Coverage Status

coverage: 81.746% (-2.4%) from 84.174% when pulling 991f483e0edc84b538ca468333250932548f8baf on CelianR:celianr/gitlab-jump-to-definition into 0871dc12bb1d092bd08831dbe1f2179c41f55342 on redhat-developer:main.

coveralls avatar May 28 '24 11:05 coveralls

Hi @msivasubramaniaan 👋 Do you have any feedback about this PR ? Tell me how you find this work / if some changes are necessary in order to be merged, this would be a great addition to the LSP in my opinion !

CelianR avatar Jun 11 '24 07:06 CelianR