odo icon indicating copy to clipboard operation
odo copied to clipboard

Odo panics when overriding parent:components:attributes:pod-overrides:spec:imagePullSecrets:name

Open AgentK9 opened this issue 2 years ago • 7 comments

/kind bug

What versions of software are you using?

Operating System: N/A (reproduced on windows and MacOS, but independent of OS or k8s back end)

Output of odo version: v3.14.0

How did you run odo exactly?

brew install odo, odo dev.

This may be an issue with the devfile library, unsure.

Actual behavior

See here for error message

Expected behavior

No error. odo dev runs as expected

Any logs, error output, etc?

See POC repo here

AgentK9 avatar Sep 26 '23 19:09 AgentK9

Hi @AgentK9!

Thanks for reporting the issue and providing a sample repro repo. FYI, the attribute for overriding properties of the pod spec is pod-overrides, not pod-override. Anyway, even with that, the issue was still there. From the stacktrace, it looks like an issue with how the Devfile library merges complex attributes when handling a parent-child relationship. I'll report this to the Devfile library repo, and when it is fixed there, we'll need to update odo accordingly.

/status blocked EDIT: Blocked by https://github.com/devfile/api/issues/1268

rm3l avatar Sep 27 '23 08:09 rm3l

Awesome! Thanks for the quick response. Edited the title to reflect your comment. Hope this gets resolved soon!

AgentK9 avatar Sep 28 '23 04:09 AgentK9

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

github-actions[bot] avatar Dec 28 '23 00:12 github-actions[bot]

This issue was closed because it has been inactive for 30 days since being marked as stale.

github-actions[bot] avatar Jan 28 '24 00:01 github-actions[bot]

Still an issue!

AgentK9 avatar Feb 01 '24 18:02 AgentK9

Still an issue!

Reopening, but still blocked by https://github.com/devfile/api/issues/1268

/reopen /remove-lifecycle stale /remove-lifecycle rotten

rm3l avatar Feb 02 '24 13:02 rm3l

@rm3l: Reopened this issue.

In response to this:

Still an issue!

Reopening, but still blocked by https://github.com/devfile/api/issues/1268

/reopen /remove-lifecycle stale /remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Feb 02 '24 13:02 openshift-ci[bot]