odo icon indicating copy to clipboard operation
odo copied to clipboard

odo preference set should not override a value if it is same as the current value

Open valaparthvi opened this issue 3 years ago • 0 comments

/kind bug

What versions of software are you using?

Operating System: Linux Output of odo version: odo v3.0.0-alpha3 (c777e3351)

How did you run odo exactly?

  1. odo preference set timeout 5
  2. odo preference set timeout 5

Actual behavior

$ odo preference view         
PARAMETER             CURRENT_VALUE
UpdateNotification    true
Timeout               5
PushTimeout           
RegistryCacheTime     
Ephemeral             
ConsentTelemetry      true

$ odo preference set timeout 5
? timeout is already set. Do you want to override it in the config Yes
Global preference was successfully updated

$ odo preference set timeout 5
? timeout is already set. Do you want to override it in the config No
Aborted by the user

odo asks if user wants to override even if the current value is same as the one user wants to set.

Expected behavior

$ odo preference view         
PARAMETER             CURRENT_VALUE
UpdateNotification    true
Timeout               5
PushTimeout           
RegistryCacheTime     
Ephemeral             
ConsentTelemetry      true

$ odo preference set timeout 5
preference 'timeout' is already set to '5'

Should not ask to override, if the current value is same as the one user is trying to set.

Any logs, error output, etc?

valaparthvi avatar Jun 14 '22 07:06 valaparthvi