compose-scheduler icon indicating copy to clipboard operation
compose-scheduler copied to clipboard

Print command output to logs

Open lorado opened this issue 2 years ago • 3 comments

I really like that ofelia prints stdout/stderr from the scheduled command directly into docker container logs. Current change make it work. I am not sure if you want to make it opt-in/-out, in case people don't like it. But tbh I don't think that somebody would like not to have that.

What do you think?

lorado avatar Feb 27 '24 23:02 lorado

@reddec

lorado avatar Mar 01 '24 08:03 lorado

@reddec Would you be able to merge and release new version? Thank you very much!

lorado avatar Mar 07 '24 16:03 lorado

@lorado @3timeslazy extremely sorry for delay!

Will you mind do it as opt-in feature?

reddec avatar May 03 '24 05:05 reddec

hey @reddec Sorry, had stuff going around on my end too. I added an optional lable "logging" which has to be set to true, to enable logs. I am not sure tho if its fine like this. I kept the rest of changes as is, only made optional copying to output buffer. Hope this works

lorado avatar Jun 17 '24 14:06 lorado

@reddec how about current implementation? I hope it is what you wanted =)

lorado avatar Jun 21 '24 08:06 lorado

@lorado fantastic! Is possible that you forgot to run gofmt -w <file> to format?

reddec avatar Jun 21 '24 15:06 reddec

@lorado fantastic! Is possible that you forgot to run gofmt -w <file> to format?

Welp, I didn't know I have to :D Should be good now

lorado avatar Jun 21 '24 20:06 lorado