redbooth
Support Rails 3.1.3 and fix reference_list missing file
Gem hasn't been updated for a while and gave me few problems, starting with Uninitialized Constant Teambox::Client then gem dependency problem.
I basically:
- updated the gem_depedencies
- add missing reference in gemspec to reference_list.rb
- fixed typo in README for client authentication. It should be :user rather than :username. It's correct in the Examples folder
Gem seems to work fine now under Rails 3.1. and Ruby 1.9.2 but not 1.9.3
hi @basharabdullah...
This PR needs to be made against the develop branch.
Oh ok. I'll do that.
On Monday, November 26, 2012, Saimon Moore wrote:
hi @basharabdullah https://github.com/basharabdullah...
This PR needs to be made against the develop branch.
— Reply to this email directly or view it on GitHubhttps://github.com/teambox/teambox-ruby-client/pull/5#issuecomment-10708520.
We've switched to using gitflow internally so my finger clicked too early
Sorry I don't see the dev branch. Is it made public?
On Monday, November 26, 2012, Bashar Abdullah wrote:
Oh ok. I'll do that.
On Monday, November 26, 2012, Saimon Moore wrote:
hi @basharabdullah https://github.com/basharabdullah...
This PR needs to be made against the develop branch.
— Reply to this email directly or view it on GitHubhttps://github.com/teambox/teambox-ruby-client/pull/5#issuecomment-10708520.
Ohh... I just read your reply. Good because I didn't see the dev branch. That explains.
Ruby 1.9.3 is giving me at least Segmentation Fault and possible bug with Ruby 1.9.3 error.
Here is the error I get: https://gist.github.com/4147334
ok thanks...
Again thanks for your work here. Our v1 API is going to be deprecated in the short term so this client will probably need an overhaul. It'll run on 1.9.3 when it does eventually come out.
I c. Thanks for the heads up
On Mon, Nov 26, 2012 at 12:32 PM, Saimon Moore [email protected]:
ok thanks...
Again thanks for your work here. Our v1 API is going to be deprecated in the short term so this client will probably need an overhaul. It'll run on 1.9.3 when it does eventually come out.
— Reply to this email directly or view it on GitHubhttps://github.com/teambox/teambox-ruby-client/pull/5#issuecomment-10709237.