gflownet icon indicating copy to clipboard operation
gflownet copied to clipboard

Harmonize use of masks

Open bengioe opened this issue 2 years ago • 0 comments

Masks are currently used somewhat ad-hoc here and there, in particular:

  • GraphSampler explicitly uses them, but it should be abstracted away
  • GraphTransformerGFN and derivatives end up applying masks themselves, but this feels like the "wrong" place

Instead, it would be good for GraphActionCategorical to do all the accounting of masks and mask-related code.

bengioe avatar Jul 17 '23 15:07 bengioe