cloudstream icon indicating copy to clipboard operation
cloudstream copied to clipboard
verified publisher icon recloudstream

feat(TV UI): Player's Top controls redesign

Open KingLucius opened this issue 1 year ago • 2 comments

  • Fixes Title alignment in case of RTL languages.
  • Adds "Restart" & "Next Episode" in top controls bar.
  • Removes the "Next Episode" button under progress seekbar.
  • Changes "Tracks" icon.
  • Margin for top bar is same on right & left.
  • Removes the back button from player loading UI.

image

KingLucius avatar Jun 17 '24 15:06 KingLucius

This might not be ready for review yet, but when pressing the reset button it might be nice to add a Y/N popup/popdown to make it impossible to make a missinput. I would also suggest that playerGoForward is always visible when hasNextEpisode because right now it hides itself when under 50%, this is due to mobile!=tv.

fire-light42 avatar Jun 19 '24 14:06 fire-light42

This might not be ready for review yet, but when pressing the reset button it might be nice to add a Y/N popup/popdown to make it impossible to make a missinput. I would also suggest that playerGoForward is always visible when hasNextEpisode because right now it hides itself when under 50%, this is due to mobile!=tv.

  • Do you mean Subtitles sync reset button ?
  • playerGoForward is visible from the beginning not after 50% as it depends on hasNextEpisode not PreloadNextEpisode

KingLucius avatar Jun 23 '24 07:06 KingLucius

Any update on this? The UI looks nice from your screenshot.

fire-light42 avatar Jul 08 '24 21:07 fire-light42

Any update on this? The UI looks nice from your screenshot.

Just got busy, will work on it next weekend

KingLucius avatar Jul 09 '24 04:07 KingLucius

I was working on redesign for the player with logo, description & episode view but let's delay this as I am super busy these days later I can resume work on the redesign

KingLucius avatar Jul 12 '24 09:07 KingLucius

So the back button will still be there I had a hope that it will be removed

Dracape avatar Jul 12 '24 13:07 Dracape

Also, we don't need a restart button

Dracape avatar Jul 12 '24 14:07 Dracape

Also, we don't need a restart button

@DestroyerBDT

I disagree, on TV, rewinding to the beginning when you want can be quite annoying.

Luna712 avatar Jul 12 '24 20:07 Luna712

Code looks good, however I would like to have text under the icons when hovering like Netflix. 👍

Ok will work on it

KingLucius avatar Jul 15 '24 15:07 KingLucius

Code looks good, however I would like to have text under the icons when hovering like Netflix. 👍

Done

Feels like this PR needs a lot of testings, don't have time for deep test these days so I need your help testing this

KingLucius avatar Jul 18 '24 14:07 KingLucius

Why was this closed?

fire-light42 avatar Jul 19 '24 11:07 fire-light42

Why was this closed?

The rebase ruined it for some reason, created a new one with additional fixes and will push today for review

KingLucius avatar Jul 19 '24 11:07 KingLucius