Tom Ritchford comments

Results 144 comments of


                                            Tom Ritchford

`set_linter` finds and replaces built-in set in Python code

I tried mightily to reproduce this issue and failed - and yet I'm certain the result must be from `set_linter` failing. See the analysis here https://github.com/pytorch/pytorch/issues/143284 _Très bizarre!_ My plan...

Uninitialised check wrong after `walrus` in `if`

I see this three times in one of my commits! `stop` is marked uninitialized [here](https://github.com/rec/pytorch/blob/0fa56b5b78e30ffe64cd331e58e389c618549385/.github/scripts/pyright_compare.py#L182-L193). `output` is marked uninitialized [here]( https://github.com/rec/pytorch/blob/0fa56b5b78e30ffe64cd331e58e389c618549385/.github/scripts/pyright_compare.py#L209-L213). There's no `and` or `or` involved anywhere. `w` is...

Is there a way to construct a dataclass directly from the command line inputs?

I have an already productionized version of this idea, and it's here: https://github.com/rec/dtyper

Is there a way to construct a dataclass directly from the command line inputs?

Oops, no, the misreading is mine. You are exactly right that is the reverse thing. However, I don't quite see how you can really get this to work. How can...