reason-cli icon indicating copy to clipboard operation
reason-cli copied to clipboard

refmt doesnt handle "//" comment syntax

Open floscr opened this issue 6 years ago • 5 comments

Refmt doesn't handle the new Comment Syntax from https://github.com/facebook/reason/pull/2254

refmt errors:
File "X.re", line 2, characters 0-2:
Error: 0: <syntax error>

Refmt version

Reason 3.3.3 @ fefe5e4d

floscr avatar Jun 18 '19 06:06 floscr

Do you plan to address this issue? I can see this as well.

erykpiast avatar Jan 20 '20 21:01 erykpiast

Yes, it (and many other issues) are fixed in the new reason-cli package that is built from Azure on every commit.

jordwalke avatar Jan 21 '20 22:01 jordwalke

@jordwalke Is there some other package to install? I have this issue with version [email protected].

erykpiast avatar Jan 22 '20 08:01 erykpiast

As far as I can tell the last update to this repo was April 2018 and this bug was raised in June 2019, so I don't see how a fix could have been released after this. This bug is still there with 3.3.3 which appears to be the latest version.

ianchanning avatar Nov 06 '20 23:11 ianchanning

You can use bsrefmt instead of refmt. As mentioned in #103 this repo appears to be archived, it's not mentioned in the editor plugins anymore.

I commented in #103 that if you're using Vim you can run bsrefmt easily enough with the comment :!bsrefmt --in-place %

bsrefmt --version gives 3.6.0 and as far as I understand refmt was just the same base bsrefmt.

bsrefmt does fix this issue and handle single line comments.

ianchanning avatar Nov 07 '20 00:11 ianchanning