bs-express

bs-express copied to clipboard

Today I was trying to customise the `setHeaders` option of the Express static middleware and noticed that the type signature in bs-express expects `Request.t`, but it should be `Response.t`. See...

samueljseay

Call for New Maintainer

9

Hi there, bs-express is looking for a new maintainer. I have been quite passively triaging issues and reviewing PRs, however I am not actively involved in the ReasonML community currently...

ncthbrt

idkjs

I discovered a dead link in the documentation. Since there was an obvious fix, I thought opening the PR would be easier than opening an issue.

calufu

Missing v1.0.2 tag?

3

Hi. I can see that npmjs.org lists the latest version of this library as `1.0.2` and the code in `master` has `"version": "1.0.2"` since 4892d02a0f12c4eb01bd200d52322881e4e8e9b7: https://github.com/reasonml-community/bs-express/blob/d1b4ea57fcd261b1943056c3c7f92b437ddd3273/package.json#L3 Has the tag just...

gabriel-bezerra

add cookie-parser as a dependency and add `.cookie` to Middleware module

2

Addresses #83 (assuming that is desired).

maxkorp

I can see how this may be intentional, but body parser is included by default, as are the middlewares for it (`Express.Middleware.json` for example), but while `Request.cookies` etc are exposed,...

maxkorp

Can't explicitly set SameSite to None

1

As of february chrome auto treats cookies with no samesite set as lax, but the library lacks a way to explicitly set it to `"none"`. I'll submit a PR momentarily...

maxkorp