materials icon indicating copy to clipboard operation
materials copied to clipboard

Submitting examples for code review for python-break examples

Open dphoenix opened this issue 11 months ago • 3 comments

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

dphoenix avatar Feb 04 '25 17:02 dphoenix

@acsany Hello! I made some edits and uploaded my updated code examples

dphoenix avatar Feb 04 '25 17:02 dphoenix

@acsany I need a little help with the linter. For my latest job, I got this message: All checks passed! would reformat /home/runner/work/materials/materials/python-break/user_input_example.py

Oh no! 💥 💔 💥 1 file would be reformatted, 3319 files would be left unchanged. Error: Process completed with exit code 1.

But I don't see anything indicating how I would need to fix this file. Can you help me understand what it's asking me to fix? Thanks so much!

dphoenix avatar Feb 07 '25 20:02 dphoenix

@acsany Created the pull request for my updated materials/code samples

dphoenix avatar Mar 17 '25 07:03 dphoenix