simple-binary-encoding icon indicating copy to clipboard operation
simple-binary-encoding copied to clipboard

Groups limit been removed ?

Open supergaga opened this issue 3 years ago • 3 comments

When numInGroup type is set to uint8, a group element may contain up to 256 entities. This type can be set to uint16 in order for the group to contain up to 65,536 entities. A group cannot contain more than 65,536 entities.

In the previous version, there was this description, but I can't find it now. Is this restriction removed?

supergaga avatar Aug 11 '22 05:08 supergaga

There is still a warning here. https://github.com/real-logic/simple-binary-encoding/blob/727281a26157a244947ec8c8afa92176c3f98a9b/sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/CompositeType.java#L207

tmontgomery avatar Aug 18 '22 15:08 tmontgomery

Okay, Perhaps a more salient explanation in docs would have been helpful in the early use.

supergaga avatar Aug 18 '22 15:08 supergaga

Sure. Feel free to send us a PR that makes the most sense.

tmontgomery avatar Aug 19 '22 14:08 tmontgomery