kotlin-toolkit icon indicating copy to clipboard operation
kotlin-toolkit copied to clipboard

The reader Activity should hold the HTTP server

Open RomanSoviak opened this issue 5 years ago • 3 comments

image

RomanSoviak avatar Mar 22 '21 09:03 RomanSoviak

Could you provide more details to reproduce the problem?

mickael-menu avatar Mar 22 '21 10:03 mickael-menu

  1. Turn on don't keep activities mode in Developer Options
  2. Open random epub

RomanSoviak avatar Mar 22 '21 10:03 RomanSoviak

This happens because it is the library Activity which is creating and retaining the server. Enabling Don't Keep Activities destroys this activity when opening a publication. I'm not sure this is a legitimate use case, because Android would destroy the whole process and not a single Activity in practice.

However, I think it makes sense to have the reader Activity retain the HTTP server, so I'll keep this issue opened. If we manage to remote the need for an HTTP server this would also solve this issue.

mickael-menu avatar Mar 22 '21 12:03 mickael-menu

Closing as the HTTP server has been removed.

qnga avatar Mar 10 '23 09:03 qnga