react-play icon indicating copy to clipboard operation
react-play copied to clipboard

disable service worker on prod

Open Angryman18 opened this issue 3 years ago • 7 comments

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Angryman18 avatar Aug 06 '22 15:08 Angryman18

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ❌ Failed (Inspect) Mar 1, 2023 at 3:52PM (UTC)

vercel[bot] avatar Aug 06 '22 15:08 vercel[bot]

disabling SW on prod is just to test if the flickering issue is gone or not. as we see the issue is gone but this PR is not yet intended to merge as i m on way to find the actual bug of happening that flickering. i will push further work and test more deployments until we have the issue gone but things wroking good. other than that let this PR open for further push.

Angryman18 avatar Aug 08 '22 09:08 Angryman18

@Angryman18 Let's put this one in the "Draft" mode. We can spring it back to PR mode when we are sure, we need a review to merge.

atapas avatar Aug 09 '22 06:08 atapas

yup sure.

Angryman18 avatar Aug 09 '22 07:08 Angryman18

Just made it draft

koustov avatar Aug 09 '22 18:08 koustov

@Angryman18 What do we do about this one?

atapas avatar Aug 18 '22 06:08 atapas

please assign this to someone else.

Angryman18 avatar Aug 18 '22 11:08 Angryman18

Donot beed this anymore

Angryman18 avatar Oct 05 '22 02:10 Angryman18

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

github-actions[bot] avatar Apr 01 '23 12:04 github-actions[bot]