socket icon indicating copy to clipboard operation
socket copied to clipboard

[WIP] Forward compatibility with react/promise 3

Open WyriHaximus opened this issue 6 years ago • 5 comments

WyriHaximus avatar Oct 10 '19 17:10 WyriHaximus

@WyriHaximus Good initiative and would love to see this getting some traction again! What are your plans for this PR? It looks like this is currently the only outstanding PR for ReactPHP to support Promise v3.

clue avatar Jun 12 '22 16:06 clue

@clue Well lets make this PR get traction again then! Will rebase and get it back into passing shape in the coming few days.

WyriHaximus avatar Jun 12 '22 16:06 WyriHaximus

@WyriHaximus Perfect! It looks like this might be blocked by https://github.com/reactphp/promise-timer/pull/54 at the moment, so I'll look into releasing the outstanding PromiseTimer version the next couple of days 👍

clue avatar Jun 12 '22 17:06 clue

@clue Cheers, still need to deal with nearly 100+ errors/failures at my local current rebase. Will push it when the tests don't get stuck anymore. (They just run for a long time at the moment.)

WyriHaximus avatar Jun 12 '22 20:06 WyriHaximus

Took about 3 minutes to run locally, will have a look at fixing errors tomorrow

WyriHaximus avatar Jun 12 '22 21:06 WyriHaximus

I've rebased this on the current 1.x branch now that #296 is in. Since https://github.com/reactphp/promise/pull/229 has been merged in the meantime, I've been able to remove most of the work-arounds in this PR and could simplify this quite a bit. In essence, this is still @WyriHaximus's original changes with all changes reverted that are no longer necessary. Let's get this shipped! :shipit:

clue avatar Aug 25 '22 09:08 clue

@clue :shipit: !

WyriHaximus avatar Aug 25 '22 09:08 WyriHaximus