promise icon indicating copy to clipboard operation
promise copied to clipboard
verified publisher icon reactphp

[WIP][2.x] Add template annotations

Open WyriHaximus opened this issue 3 years ago • 5 comments

WyriHaximus avatar May 19 '22 15:05 WyriHaximus

FYI just filed https://github.com/reactphp/promise/pull/227 and https://github.com/reactphp/promise/pull/228

Both are a getting support out there and then improve on it kind of PR.

WyriHaximus avatar Jun 21 '22 21:06 WyriHaximus

Sorry for barging but I am really interested in this PR and would like to remove my own stubs. Should I wait for merge or use PR branch instead?

zmitic avatar Jan 06 '23 16:01 zmitic

@zmitic Honestly same, will have a look at this again during the weekend and hopefully, this got resolved in recent PHPStan updates. But currently support for mixed scalar and scalar through PromiseInterface is blocking this

WyriHaximus avatar Jan 06 '23 23:01 WyriHaximus

Opened https://github.com/phpstan/phpstan/issues/8707 to hopefully get the last few functions fully in

WyriHaximus avatar Jan 15 '23 22:01 WyriHaximus

PR's to address our current template param buggy use can be found here:

  • https://github.com/reactphp/dns/pull/212
  • https://github.com/reactphp/promise-timer/pull/63
  • https://github.com/reactphp/promise-stream/pull/35
  • https://github.com/reactphp/http/pull/487

WyriHaximus avatar Jan 21 '23 14:01 WyriHaximus