child-process icon indicating copy to clipboard operation
child-process copied to clipboard
verified publisher icon reactphp

[0.7.x] Improve PHP 8.5+ support by replacing binary cast with string cast

Open kubawerlos opened this issue 5 months ago • 4 comments

kubawerlos avatar Aug 22 '25 09:08 kubawerlos

hey, you think it's sth merge-able ? :thanks:

keradus avatar Oct 17 '25 10:10 keradus

up PHP 8.5 is out

Fneufneu avatar Nov 24 '25 07:11 Fneufneu

Hey @kubawerlos, thank you for putting this PR together. Could you do either of these things for me so we can merge this PR in:

  • Check the maintainers can edit checkbox
  • Squash the commits into one and use the commit message from a6b551aa8c876fd0448d856632fa3809a4fc7520

WyriHaximus avatar Dec 08 '25 17:12 WyriHaximus

  • Check the maintainers can edit checkbox
  • Squash the commits into one and use the commit message from a6b551a

@WyriHaximus as I make a PR not from my personal account, but from org, I cannot do the former (I am assuming anyone can always squash the commits themself when merging), so I did the latter.

kubawerlos avatar Dec 08 '25 18:12 kubawerlos

@kubawerlos Thank you for looking into this!

The test suite currently reports this minor deprecation on PHP 8.5+, may I ask you to address this as well as part of this PR? :+1:

PHP Deprecated:  Non-canonical cast (integer) is deprecated, use the (int) cast instead in /home/runner/work/child-process/child-process/tests/AbstractProcessTest.php on line 538

clue avatar Dec 20 '25 11:12 clue

@clue fixed

kubawerlos avatar Dec 21 '25 20:12 kubawerlos