reactjs
Fix runtime error in a broken clock challenge caused by missing element check
What’s the issue?
The Clock challenge component throws a runtime error because it tries to set the className on an element that does not yet exist in the DOM. Specifically, document.getElementById('time') returns null during the initial render, causing this error:
This PR adds a simple existence check before accessing the element’s className, preventing the runtime error while preserving the original logic
Hi @soralvy!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Size changes
📦 Next.js Bundle Analysis for react-dev
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@gaearon is the error intentional for the challenge? The text sounds like it shouldn't, but looking at the history I don't see how this would have ever worked without an error?
