react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

[Bug]: No new lines in error decoder errors

Open rickhanlonii opened this issue 1 year ago • 4 comments

Summary

Check out this error: https://react.dev/errors/418

It's formatted all on one line, but should have new lines.

Page

https://react.dev/errors/418

Details

No response

rickhanlonii avatar Apr 05 '24 14:04 rickhanlonii

Hi, could you please assign this issue to me? I submitted a pull request separately and signed the CLA. Thank you

wheeler6123 avatar Apr 06 '24 01:04 wheeler6123

@rickhanlonii Good morning Ricky, just wanted to follow up on this issue, I submitted a pull request under #6735 and wasn't sure if there was any feedback for my proposed solution. Thanks!

wheeler6123 avatar Apr 16 '24 14:04 wheeler6123

Seems to include newlines now:

Screenshot 2024-04-20 at 21 35 19

-- https://react.dev/errors/418

The only thing missing is handling empty strings. The hydration errors will always produce https://react.dev/errors/418?args[]= but that's interpreted as missing unfortunately.

eps1lon avatar Apr 20 '24 19:04 eps1lon

I could reproduce it locally though it wasn't consistent. Should be fixed with https://github.com/reactjs/react.dev/pull/6767. https://github.com/reactjs/react.dev/pull/6735 didn't seem to fix this locally.

eps1lon avatar Apr 20 '24 20:04 eps1lon