react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

docs: add missing import statement

Open skoyah opened this issue 2 years ago • 7 comments

The current Beta documentation shows a code snippet a little different from the one available in the Sandbox.

It seems that the React import is missing from the documentation.

Steps to reproduce:

  • Fork the first code sandbox that appears on the tutorial on the "Tutorial Setup" section (https://beta.reactjs.org/learn/tutorial-tic-tac-toe#setup-for-the-tutorial)

Screenshot 2023-03-10 at 18 47 17

Screenshot 2023-03-10 at 20 05 06

This PR fixes the documentation to be in sync with the sandbox example.

skoyah avatar Mar 10 '23 19:03 skoyah

Hi @skoyah!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 10 '23 19:03 facebook-github-bot

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

github-actions[bot] avatar Mar 10 '23 19:03 github-actions[bot]

These react imports might not be needed 🤔. constantly throughout the documentation we don't have react imported I guess.

harish-sethuraman avatar Mar 10 '23 20:03 harish-sethuraman

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Mar 10 '23 21:03 facebook-github-bot

I come from Vueland and is my first contact with React. Started following the tutorial and encountered this "error".

skoyah avatar Mar 10 '23 21:03 skoyah

It should work even if we remove the import of React in the codesandbox and it should be fine.

harish-sethuraman avatar Mar 11 '23 05:03 harish-sethuraman

So perhaps we should remove it from the sandbox itself?

Having that import statement does not add anything.

Beginners might even wonder why is there in the first place.

skoyah avatar Mar 14 '23 10:03 skoyah