react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Fix inaccurate description of Challenge 4

Open Tunzeki opened this issue 2 years ago • 3 comments

In Challenge 4 (Remove unnecessary state), the last sentence of the first paragraph says that the alert always shows "Hello, !". It doesn't. What actually happens is that "Hello, !" is alerted the first time you enter a name, but subsequently, the name you entered just before that time is shown.

Example:

  1. Say you enter John the first time. Alert: "Hello, !"

  2. Next, you entered Jane. Alert: "Hello, John!"

  3. Finally, you entered Jack. Alert: "Hello, Jane!"

Tunzeki avatar Mar 04 '23 21:03 Tunzeki

Hi @Tunzeki!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Mar 04 '23 21:03 facebook-github-bot

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

github-actions[bot] avatar Mar 04 '23 21:03 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Mar 04 '23 23:03 facebook-github-bot