react-tabs icon indicating copy to clipboard operation
react-tabs copied to clipboard

Why are <li> being used as the clickable items

Open harryhaigh opened this issue 5 years ago • 2 comments

Isn't it best practice to use <button> instead of <li> as the clickable elements for tabs. If this library is focused on accessibility then why isn't it following best practices?

harryhaigh avatar Jan 06 '21 15:01 harryhaigh

I agree, maybe we can refactore this part with a different way to do a clickable tag.

AgmarTorres avatar May 20 '21 03:05 AgmarTorres

I just had an accessibility review performed on a page using this library. This issue was called out. Replacing or even nesting with a button would solve the problem. Unfortunately I don't see any way to alter the <Tab> component either to make it work correctly.

pookmish avatar Jun 22 '23 17:06 pookmish