react-rails icon indicating copy to clipboard operation
react-rails copied to clipboard

On certain JS runtimes, send warning notice.

Open BookOfGreg opened this issue 7 years ago • 1 comments

Related to #947 and any other issue mentioning Set, Node < 6 or RubyRacer.

All of those issues are due to old JS runtimes. I would welcome a PR that detects invalid JS runtimes and warns the user to update system Node or use a libv8 gem that is up to date.

Relates to https://github.com/rubygems/rubygems/issues/1811 as having miniracer be an optional dependency would aid this effort.

I would also welcome a PR that updates the readme to document the JS runtimes.

BookOfGreg avatar Oct 19 '18 12:10 BookOfGreg

Hi! I can take look at this. PR to come

HeroProtagonist avatar Oct 20 '18 18:10 HeroProtagonist