react-modal icon indicating copy to clipboard operation
react-modal copied to clipboard
verified publisher icon reactjs

[added] isNested prop

Open Jarch09 opened this issue 7 years ago • 5 comments

Changes proposed:

  • adds isNested: bool (optional) prop, which gives you the option of not removing the modal backdrop.

Why? This enables Russian doll nesting, so you can have multiple modals open on top of each other.

Acceptance Checklist:

  • [x] The commit message follows the guidelines in CONTRIBUTING.md.
  • [x] Documentation (README.md) and examples have been updated as needed.
  • [x] If this is a code change, a spec testing the functionality has been added.
  • [ ] If the commit message has [changed] or [removed], there is an upgrade path above.

Jarch09 avatar Oct 25 '18 06:10 Jarch09

Coverage Status

Coverage increased (+0.06%) to 86.758% when pulling 4c17fc42995ece0e8a332ec74e41ea3bca5285e6 on Jarch09:add-nesting into 1b561fc54f107df583281667eb92e7975ec33ba8 on reactjs:master.

coveralls avatar Oct 25 '18 07:10 coveralls

Hi @Jarch09, I'll have a look on all PRs this weekend. Thanks!

diasbruno avatar Oct 25 '18 12:10 diasbruno

Hey you have a chance to check this out?

Jarch09 avatar Oct 31 '18 05:10 Jarch09

@Jarch09 Yep. This looks good. I'm thinking of push this to v4.

diasbruno avatar Oct 31 '18 12:10 diasbruno

So is this going to be pulled at any point?

Does this change only remove the background effect or does it also affect modal stacking order?

willsmanley avatar Apr 29 '20 06:04 willsmanley