react-modal icon indicating copy to clipboard operation
react-modal copied to clipboard

[fixed] Don't set aria-modal attribute when running on apple's Webkit.

Open leonascimento opened this issue 7 years ago • 4 comments

Fixes #611.

-This merge request should prevent that the VoiceOver fails.

Changes proposed: -Define false to aria-modal when is webkit.

Upgrade Path:

-Change the value when is webkit.

-isSafariDesktop transforming this function in a helper function to use on others places.

Acceptance Checklist:

  • [x] All commits have been squashed to one.
  • [x] The commit message follows the guidelines in CONTRIBUTING.md.
  • [ ] Documentation (README.md) and examples have been updated as needed.
  • [ ] If this is a code change, a spec testing the functionality has been added.
  • [x] If the commit message has [changed] or [removed], there is an upgrade path above.

leonascimento avatar Feb 20 '18 03:02 leonascimento

Coverage Status

Coverage increased (+0.5%) to 90.073% when pulling 287e79f7252d8ebf9a2620fcffb7f159b93e91bb on leonascimento:fix/voice-over-fails into 241b8a697c2141f1631b9666bda07b01f4972f56 on reactjs:master.

coveralls avatar Feb 20 '18 03:02 coveralls

@diasbruno @MaksimKniazeu I did an update on this pull request. Can you make the code review?

leonascimento avatar Feb 23 '18 02:02 leonascimento

Uh... I don't maintain this library.

markerikson avatar Feb 23 '18 02:02 markerikson

@markerikson sorry man, I wrote wrong.

leonascimento avatar Feb 23 '18 13:02 leonascimento