react-codemod icon indicating copy to clipboard operation
react-codemod copied to clipboard

update-react-imports changes line endings (LF -> CRLF)

Open tpettrov opened this issue 5 years ago • 2 comments

I recently started update-react-imports and it works as expected but re-wrote the line endings from LF to CRLF, probably because I'm on Windows but would expect that it doesn't change them if possible.

tpettrov avatar Oct 22 '20 08:10 tpettrov

This is functionality from jscodeshift, so the issue should probably be filed there. However, one of the assumptions we have about people running codemods, is that they also run something like prettier (or whatever your code formatter is) manually after running the codemod. Does that advice seem reasonable in this case?

threepointone avatar Oct 22 '20 10:10 threepointone

Advice is reasonable due to the fact that the issue should probably be filled to jscodeshift :) Thank you.

tpettrov avatar Oct 22 '20 13:10 tpettrov