react-chartjs icon indicating copy to clipboard operation
react-chartjs copied to clipboard

v2: support horizontalBar chart

Open ghost opened this issue 9 years ago • 3 comments

Chart.js supports horizontalBar charts as of lately, see: http://jsfiddle.net/3xts05xu/

But it's impossible to pass horizontalBar type, because type gets lowercased on this line: https://github.com/jhudson8/react-chartjs/blob/chartjs-v2/lib/core.js#L76

What is the purpose behind .lowercase()? Wouldn't it be better to allow to pass any type and leave it up to chart js to throw error?

ghost avatar May 20 '16 17:05 ghost

I put a PR #122 that addresses this.

OddEssay avatar Jun 23 '16 10:06 OddEssay

@OddEssay Great work 👍

ghost avatar Jun 23 '16 12:06 ghost

@OddEssay How do you get HorizontalBar to work in your branch? It returns undefined when I reference it.

ramimazid avatar Oct 04 '16 03:10 ramimazid