pl.react.dev icon indicating copy to clipboard operation
pl.react.dev copied to clipboard

Learn / Referencing Values with Refs

Open piotr-pajak opened this issue 9 months ago • 3 comments

Translation of the page Learn / Escape Hatches / Referencing Values with Refs into 🇵🇱 .

[!NOTE]
This is my first translation, any feedback or suggestions for improvement would be greatly appreciated 😉

piotr-pajak avatar Mar 22 '25 19:03 piotr-pajak

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
pl-legacy-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2025 9:22pm

vercel[bot] avatar Mar 22 '25 19:03 vercel[bot]

In general very fast and very good translation! Nice start! 🚀

There are minor things to correct, nothing serious. Don't be scared about number of suggestions. I have a keen eye for details. This is nothing personal 😉

Thanks for the extensive feedback! I missed quite a few things, especially regarding the impersonal form of verbs. Your feedback also answers many of the questions that I had during the translation process.

I'll apply the feedback in the next few days and will mention you once the changes have been implemented.

I also have a quick question about resolving conversations: what's the preferred approach on this repository? Should the reviewer resolve them, or the person who implements the fixes 🤔?

piotr-pajak avatar Mar 27 '25 23:03 piotr-pajak

That's the spirit! 🔥

I am not aware of any specific way of working in this project regarding resolving conversations, but I would say that if you simply agree with suggestion or fix is very simple and it can be done in one way only, you can apply it and resolve. I think this will be 95% of cases.

You can left conversation open in rare cases when change can be done in couple of ways and you are not sure how it will be received by the reviewer.

dawidsabat avatar Mar 28 '25 08:03 dawidsabat

Hey @dawidsabat, Feedback applied. Can you let me know if it's all good now? If yes, I'd like to reserve the translation for Escape Hatches / Manipulating the DOM with Refs 😉

piotr-pajak avatar Apr 02 '25 18:04 piotr-pajak

Hey @dawidsabat, Feedback applied. Can you let me know if it's all good now? If yes, I'd like to reserve the translation for Escape Hatches / Manipulating the DOM with Refs 😉

Great! I will review it tomorrow. Reservation done 😉

dawidsabat avatar Apr 02 '25 21:04 dawidsabat

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 106.5 KB (🟡 +15 B) 210.88 KB
/500 106.5 KB (🟡 +15 B) 210.88 KB
/[[...markdownPath]] 108.34 KB (🟡 +15 B) 212.71 KB
/errors 106.71 KB (🟡 +15 B) 211.09 KB
/errors/[errorCode] 106.69 KB (🟡 +15 B) 211.07 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar Apr 14 '25 20:04 github-actions[bot]