ko.react.dev icon indicating copy to clipboard operation
ko.react.dev copied to clipboard

update keeping components pure

Open BeomyeonAndrewKim opened this issue 3 years ago • 1 comments

안녕하세요.

너무 제출이 늦어서 죄송합니다.

리뷰 부탁드릴게요!

감사합니다.

Progress

BeomyeonAndrewKim avatar Oct 03 '22 07:10 BeomyeonAndrewKim

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/learn/keeping-components-pure 56.57 KB (🟡 +1.47 KB) 141.24 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions[bot] avatar Oct 03 '22 07:10 github-actions[bot]

@gnujoow 두 요구사항 모두 완료해서 푸시했습니다. 추가적으로 npm run check-all 했을때 lint에서 계속 fail이 일어나서 CustomPreset.tsx 파일에 변경이 있습니다. 참고해주세요.

BeomyeonAndrewKim avatar Nov 21 '22 13:11 BeomyeonAndrewKim

안녕하세요! React docs 한국어 번역을 재개하기 위해 beta docs와 최신 문서들을 현 레포지토리에 반영하고, 번역 가이드라인을 재정비하는 중입니다. 일단의 정리를 위해 현재 열려있는 PR은 닫으려고 하니 양해 부탁드리고, 새로운 가이드라인에 맞춰 PR을 다시 올려주시면 감사하겠습니다. :)

MaxKim-J avatar Feb 04 '23 15:02 MaxKim-J