id.react.dev icon indicating copy to clipboard operation
id.react.dev copied to clipboard

docs: translate You Might Not Need An Effect

Open averrows opened this issue 2 years ago • 9 comments

Bahasa translation for Escape Hatches > You might not need an effect.

Issue: #330

Closes #390

averrows avatar Apr 27 '23 22:04 averrows

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 28 '23 15:04 github-actions[bot]

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 28 '23 15:04 github-actions[bot]

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Apr 28 '23 15:04 github-actions[bot]

@averrows Converted back to draft because starting from "Lifecycle of reactive effects" it's not been translated yet.

mhaidarhanif avatar Apr 28 '23 15:04 mhaidarhanif

@averrows Hello, any progress on the remaining untranslated content? If we don't hear from you within 24-48 hours, we're going to reassign this PR to someone else.

resir014 avatar Jun 13 '23 09:06 resir014

Hi @resir014, per my understanding, "Lifecycle of reactive effects" and parts after that are on different issues ex: https://github.com/reactjs/id.react.dev/issues/391. And my translation of "You Might Not Need an Effect" is all done and I had applied the reviews. Or do I understand it wrong?

averrows avatar Jun 14 '23 04:06 averrows

Wait, that's why it's confusing because it should not translate only one section of the page. All translation PRs need to translate one whole page.

@averrows This connected PR should translate the whole page of "You Might Not Need an Effect": https://id.react.dev/learn/you-might-not-need-an-effect

That issue is for that whole page. My recommendation would be fixing this by translating the intended page of "You Might Not Need an Effect", not the "Escape hatches" because it's been translated here: https://github.com/reactjs/id.react.dev/pull/522

So there's actually a misunderstanding of translating the page.

Check again from the issue list:

image

Check again from the initial issue and link to the page:

image

cc @resir014 @mazipan @zainfathoni @r17x

mhaidarhanif avatar Jun 14 '23 06:06 mhaidarhanif

Yes, as @mhaidarhanif mentioned above. If you're unable to do it, then we can reassign this PR to someone else. @averrows

resir014 avatar Jun 26 '23 17:06 resir014

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jul 16 '23 13:07 github-actions[bot]