hi.react.dev icon indicating copy to clipboard operation
hi.react.dev copied to clipboard
verified publisher icon reactjs

Review Process

Open arshadkazmi42 opened this issue 6 years ago • 3 comments

For reviewing we follow this process.

  • Add the list of all the section names (in english) in the pull request description, which reviewer will mark check as and when the review of each section is getting completed (For reference check this PR #17 )
  • You should not resolve review feedback, you can add a comment or an 👍 emoji to every review comment once it's resolved and pushed.
  • A reviewer will review the changes and resolve the conversations

Review Phases

  • Currently we have two phases of review
    • First review is done by Arshad (@arshadkazmi42 )
    • Second review is done by Saransh (@saranshkataria )

arshadkazmi42 avatar Mar 06 '19 17:03 arshadkazmi42

We should also add that if the file is large, add a list of sections so that the reviewer can check the ones we have reviewed?

saranshkataria avatar Mar 06 '19 23:03 saranshkataria

We should also add that if the file is large, add a list of sections so that the reviewer can check the ones we have reviewed?

Added this point also 👍

arshadkazmi42 avatar Mar 07 '19 03:03 arshadkazmi42

Also, try and have the section names in english so as to avoid any confusions if the translation for the heading changes

saranshkataria avatar Mar 07 '19 03:03 saranshkataria