gu.react.dev icon indicating copy to clipboard operation
gu.react.dev copied to clipboard
verified publisher icon reactjs

feat: Translate Conditional Rendering

Open nirmitkotadiya opened this issue 9 months ago • 13 comments

📝 Description

This PR adds the official Gujarati translation for the "Conditional Rendering" page from the React documentation. The content has been carefully translated to retain its original meaning, technical accuracy, and readability for Gujarati-speaking developers.

✅ Checklist

  • [x] Page fully translated
  • [x] Checked for grammar, clarity, and developer tone
  • [x] Verified formatting and links
  • [x] Screenshots added for translated UI

📷 Screenshots

Screenshot 2025-04-13 164321 Screenshot 2025-04-13 164353 Screenshot 2025-04-13 164412

🔗 Linked Issue

References #[issue-number]](https://github.com/reactjs/gu.react.dev/issues/1#issuecomment-2561845663)

🧪 How to check?

Deployment preview : https://gu-react-7uudurjb1-fbopensource.vercel.app/learn/conditional-rendering

nirmitkotadiya avatar Apr 13 '25 11:04 nirmitkotadiya

Thanks @nirmitkotadiya I will review it in this week.

harshilparmar avatar Apr 17 '25 00:04 harshilparmar

Have you looked into this section for the following guidelines?

harshilparmar avatar Apr 23 '25 17:04 harshilparmar

Yes, I’ve already reviewed this section. I’ll recheck it if any issues are found.

nirmitkotadiya avatar Apr 24 '25 02:04 nirmitkotadiya

Could you please clarify what the issue is in this PR? I've already checked it twice.

nirmitkotadiya avatar May 03 '25 13:05 nirmitkotadiya

Could you please clarify what the issue is in this PR? I've already checked it twice.

I was waiting for your reply. I will take a look and let you know. Thanks.

harshilparmar avatar May 03 '25 13:05 harshilparmar

Hello @harshilparmar, all changes have been completed from my side. Please review and merge. Commit ID: https://github.com/reactjs/gu.react.dev/pull/89/commits/4694c1eec1b9f2d701c394fb0404dbf86d53b13c

nirmitkotadiya avatar May 15 '25 15:05 nirmitkotadiya

@nirmitkotadiya It seems like you have replaced all the * with _. I hope you are running yarn check-all after making changes locally. Please ensure that your changes don't disrupt the current build process.

harshilparmar avatar May 15 '25 16:05 harshilparmar

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar May 15 '25 16:05 github-actions[bot]

@harshilparmar I intended to run the check, but encountered a Prettier error. So I applied the changes manually—please review them.

nirmitkotadiya avatar May 15 '25 16:05 nirmitkotadiya

Can you please check why it shows a red cross besides your commit? Screenshot 2025-05-15 at 11 13 04 PM

harshilparmar avatar May 16 '25 03:05 harshilparmar

@harshilparmar How can this issue be resolved?

image image

nirmitkotadiya avatar May 16 '25 04:05 nirmitkotadiya

@nirmitkotadiya, I would like to ask you to have some patience and not to do anything that is not standard for this official repo. Give me some time, I will look into this. Screenshot 2025-05-16 at 7 40 44 AM

harshilparmar avatar May 16 '25 11:05 harshilparmar

Okay, I will wait. This was a mistake on my part, and I’ll make sure it doesn’t happen again in the future.

nirmitkotadiya avatar May 16 '25 11:05 nirmitkotadiya

I'm merging this PR into main after considering that Vercel authorization has some issues for generating a new preview link.

harshilparmar avatar Jul 06 '25 14:07 harshilparmar

Thanks for merging the PR! Kindly tick the Conditional Rendering issue (@nirmitkotadiya) as it has been successfully merged.

nirmitkotadiya avatar Jul 07 '25 05:07 nirmitkotadiya

I figured out the issue. For your information, it happened because you tried to commit directly into the main branch. I assume you forgot to pull the latest main changes while incorporating PR reviews' changes.

However, to maintain a clean git history, I had to remove those commits from the main branch. I would appreciate it if you could make a new small pr for those last changes.

Please make sure to sync your fork with the latest main changes.

Main branch history before: Screenshot 2025-07-06 at 8 33 53 PM

harshilparmar avatar Jul 07 '25 13:07 harshilparmar

Hello @harshilparmar,

As per your request, I’ve created a new PR with the necessary changes. Please review it, and if any further updates are required, feel free to let me know.

PR Link: #103 – Translate Conditional Rendering

nirmitkotadiya avatar Jul 09 '25 17:07 nirmitkotadiya

@nirmitkotadiya Thank you so much for your wonderful contribution. I appreciate your efforts. Congratulation 🎉

harshilparmar avatar Aug 13 '25 14:08 harshilparmar