refit icon indicating copy to clipboard operation
refit copied to clipboard

Ensure two interfaces with the same name do not cause compile errors

Open dtewinkel opened this issue 2 years ago • 4 comments

What kind of change does this PR introduce?

Fixes bug #1261.

What is the current behavior? See bug #1261. In short, source generator fails if there are more than two interfaces with the same name.

What is the new behavior? Any number of interface with the same name is supported by extending the methodology that supported two interfaces with the same name.

What might this PR break? Nothing that I expect.

Please check if the PR fulfills these requirements

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

Other information:

dtewinkel avatar Jul 20 '23 19:07 dtewinkel

Is there any documentation I should update? Version history or so?

dtewinkel avatar Jul 20 '23 19:07 dtewinkel

We are starting to evaluate another release. So will go through these PRs soon. thanks for the contribution.

glennawatson avatar Oct 01 '23 03:10 glennawatson

I just added a fix for the unit tests.

dtewinkel avatar Oct 02 '23 18:10 dtewinkel

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.62%. Comparing base (6ebeda5) to head (d0d1c5a). Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
- Coverage   87.73%   86.62%   -1.11%     
==========================================
  Files          33       34       +1     
  Lines        2348     2064     -284     
  Branches      294      296       +2     
==========================================
- Hits         2060     1788     -272     
+ Misses        208      199       -9     
+ Partials       80       77       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 09 '23 14:12 codecov[bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Jun 24 '24 00:06 github-actions[bot]