reactdevske-website icon indicating copy to clipboard operation
reactdevske-website copied to clipboard

Implement the Footer Section

Open orama254 opened this issue 3 years ago • 7 comments

Depends on

  • Logo Component #84

What feature are you adding?

Footer Section

Describe your issue

Requirements

  • Create a component named Footer in the components folder that implements the screenshots below.
  • The menu items are anchor links which should smoothly scroll to the relevant section when clicked.
  • The sections do not need to exist for this ticket, only ensure that the links are correct.
  • Reuse the Logo component.
  • Include the component in index.page.tsx.
  • Create a new test file in the e2e folder named footer.spec.ts and add a test that verifies that clicking each of the 3 links in the component navigates to the correct URLs.

SCREENSHOTS

Desktop footer-section

Mobile footer-section-mobile

Figma Design

Acceptance Criteria

  • [ ] When the "About Us" menu is clicked, the URL changes to /#about-us.
  • [ ] When the "Events" menu is clicked, the URL changes to /#events.
  • [ ] When the "Contact" menu is clicked, the URL changes to /#contact-us.
  • [ ] The implementation should match the design - text content, typography, capitalization and spacing.
  • [ ] The UI should be responsive and work well on both desktop and mobile viewports.
  • [ ] The footer.spec.ts test should pass on both Chrome, Firefox and Safari.

orama254 avatar Oct 13 '22 08:10 orama254

hey @orama254 can I do this? please assign it to me.

yashsarnaik22 avatar Oct 13 '22 08:10 yashsarnaik22

Hey @yashsarnaik22

Go ahead, remember to go through our contribution guidelines and also evaluate the acceptance criteria before submitting a pull request.

Also note that this issue depends on #84 . Check it out an let me know if you are ok implementing it or can wait for it to be implemented.

Happy hacking!!!

orama254 avatar Oct 13 '22 08:10 orama254

Yes I will take the logo component on figma. And I'll create a responsive footer component. I'll submit a PR in a few hours. Is that okay?

yashsarnaik22 avatar Oct 13 '22 10:10 yashsarnaik22

Yes, @yashsarnaik22 that is ok.

for quality purposes I would advise that you make a separate PR for issue #84 first before creating a PR for this issue.

orama254 avatar Oct 13 '22 11:10 orama254

Thank you! On it.

yashsarnaik22 avatar Oct 13 '22 13:10 yashsarnaik22

@orama254 the header section is not done yet? I wanted to provide href to the links

yashsarnaik22 avatar Oct 15 '22 17:10 yashsarnaik22

@orama254 the header section is not done yet? I wanted to provide href to the links

@yashsarnaik22 This ticket does not depend on the Header section. The links that should be provided are already described in the acceptance criteria above. They might be broken at first, but once all the other tickets are done, the relevant sections where they link will be present.

This ticket only depends on #84, which you have to wait to be implemented and merged since you need to reuse the logo in the footer.

antosan avatar Oct 17 '22 02:10 antosan

Hey @yashsarnaik22

I'm following up to see how far you have reached with the implementation of this issue.

Let me know if you also need assistance on anything.

orama254 avatar Nov 01 '22 10:11 orama254

Hello @devKiratu would you be up for this task?

orama254 avatar Nov 10 '22 20:11 orama254

Hello @devKiratu would you be up for this task?

Hi @orama254 , Sure! Please assign me

devKiratu avatar Nov 11 '22 05:11 devKiratu