reactdevske-website icon indicating copy to clipboard operation
reactdevske-website copied to clipboard

Add git hooks

Open EspiraMarvin opened this issue 2 years ago • 4 comments

What feature are you adding?

adding git hooks with husky

Describe your issue

We can use Husky to lint commit messages, run tests, and lint code when you commit or push code. We can specify commit message formats, add pre-commit and post-merge hooks

EspiraMarvin avatar Jan 21 '24 18:01 EspiraMarvin

@EspiraMarvin Great feature suggestion.

Are there specific tasks on this project that you want to target with the git hooks?

orama254 avatar Jan 27 '24 18:01 orama254

@orama254 There are specific tasks to handle with git hooks here:

  1. Automate code linting after staging file changes
  2. Enforcing a formal(one-way) format for writing commit messages. this formatting will be helpful to track meaningful changes/releases of the app via the CHANGELOG, Of course, other use cases exist, but the above two can be applied to this project.

EspiraMarvin avatar Jan 29 '24 12:01 EspiraMarvin

@EspiraMarvin

Could you create one that runs the validate script? This has all the necessary steps e.g linting, testing and typechecking.

If yes then I can give you a go ahead and assign you this issue

orama254 avatar Feb 14 '24 06:02 orama254

@orama254 yes, that's possible, you can assign me the issue

EspiraMarvin avatar Feb 14 '24 11:02 EspiraMarvin

@orama254 is this still open ?

I would like to handle it

SnowJunior avatar May 16 '24 18:05 SnowJunior

@orama254 is this still open ?

I would like to handle it

hey @SnowJunior it's been sorted on pull #141

orama254 avatar May 23 '24 07:05 orama254

Closing as complete.

orama254 avatar May 23 '24 07:05 orama254