hooks icon indicating copy to clipboard operation
hooks copied to clipboard

useMergedRef not being exported by index

Open bpas247 opened this issue 6 years ago • 5 comments

Probably just a missed step in #9, but we should export the useMergedRef hook from src/index.ts.

bpas247 avatar Aug 09 '19 23:08 bpas247

The FocusManager is also not reexported

Shadowlauch avatar Nov 05 '19 12:11 Shadowlauch

Actually, a ton of stuff isn't. Should they be?

taion avatar Nov 22 '19 19:11 taion

probably, but i don't think about it since we cherry-pick

jquense avatar Nov 22 '19 21:11 jquense

Should we get rid of index then?

taion avatar Nov 22 '19 21:11 taion

Getting rid of the index would introduce a breaking change though. I personally quite like the named exports from an index and with proper tree shaking it does not introduce unnessecary code.

Shadowlauch avatar Nov 23 '19 17:11 Shadowlauch