react-navigation.github.io icon indicating copy to clipboard operation
react-navigation.github.io copied to clipboard
verified publisher icon react-navigation

docs: Incorrect import in handling-iphonex.md

Open guanguangua opened this issue 4 years ago • 1 comments

In the example the SafeAreaView is imported from react-native-safe-area-view, but in the description it is imported from react-navigation, which may cause confusion.

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. /versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. :+1:

guanguangua avatar May 18 '21 08:05 guanguangua

Deploy preview for react-navigation-docs ready!

Built with commit 7921b30b16bc445f4b6c35f22ed7586b8f8eeb74

https://deploy-preview-996--react-navigation-docs.netlify.app

netlify[bot] avatar May 18 '21 08:05 netlify[bot]

Thanks for the PR. However this seems to be fixed, so I'm closing this.

satya164 avatar Oct 21 '22 10:10 satya164