react-navigation.github.io icon indicating copy to clipboard operation
react-navigation.github.io copied to clipboard

Update params doc page to mention push function signature & remove im…

Open john-raymon opened this issue 4 years ago • 1 comments

…proper “an” placement

  • Remove “an” before word user with Y consonant sound
  • include push alongside mentioning of navigate in beginning of page, that’s also mentioned in the summary at the end.

READ ME PLEASE!

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. /versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. :+1:

john-raymon avatar Feb 16 '21 08:02 john-raymon

Deploy preview for react-navigation-docs ready!

Built with commit adb08c5f4927594f976a2f27b6eed6e49b9a38bd

https://deploy-preview-932--react-navigation-docs.netlify.app

netlify[bot] avatar Feb 16 '21 08:02 netlify[bot]

Thanks for the PR. I'm closing this since this change is for an older version of React Navigation. Feel free to send a new PR for the current version of React Navigation.

satya164 avatar Oct 21 '22 09:10 satya164