react-navigation.github.io icon indicating copy to clipboard operation
react-navigation.github.io copied to clipboard

Some misunderstanding

Open MaxBay2020 opened this issue 5 years ago • 1 comments

On summary section, the 1st tip: navigation.navigate('RouteName') pushes a new route to the stack navigator if it's not already in the stack, otherwise it jumps to that screen. The word 'jump' might cause misunderstanding, using stays would be better. This is 'otherwise it stays to that screen'

READ ME PLEASE!

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. /versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. :+1:

MaxBay2020 avatar Jan 14 '21 16:01 MaxBay2020

:heavy_check_mark: Deploy preview for react-navigation-docs ready!

:hammer: Explore the source changes: 21ed6815b772e4b5020abdab24c31d370fd4cb97

:mag: Inspect the deploy logs: https://app.netlify.com/sites/react-navigation-docs/deploys/60006d2d5c5bb50007cf582b

:sunglasses: Browse the preview: https://deploy-preview-923--react-navigation-docs.netlify.app

netlify[bot] avatar Jan 14 '21 16:01 netlify[bot]

Thanks for the PR. However "stays to that screen" doesn't seem grammatically correct so it seems more confusing. I'm closing this since it's an old PR, but feel free to send a new PR with alternative phrasing.

satya164 avatar Oct 21 '22 09:10 satya164