react-navigation.github.io icon indicating copy to clipboard operation
react-navigation.github.io copied to clipboard

Update material-bottom-tab-navigator.md

Open Ripplz opened this issue 5 years ago • 2 comments

The theme prop doesn't have any effect on this component's tab bar label font as it does react-native-paper's BottomNavigation component, so after digging through the source code, I found that you can pass a fully customized React component as this prop instead of just a string.

READ ME PLEASE!

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. /versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. :+1:

Ripplz avatar Nov 04 '20 06:11 Ripplz

Deploy preview for react-navigation-docs ready!

Built with commit 04e5c0d1f05b6f8299b6234768a92c6b0d49a24b

https://deploy-preview-887--react-navigation-docs.netlify.app

netlify[bot] avatar Nov 04 '20 06:11 netlify[bot]

What do you mean by "The theme prop doesn't have any effect on this component's tab bar label font as it does react-native-paper's BottomNavigation component"?

satya164 avatar Nov 30 '20 13:11 satya164

Thanks for the PR, however, the types don't allow to pass anything other than a string. While passing a react element works right now it's not supported and can break in the future.

satya164 avatar Oct 21 '22 08:10 satya164