react-navigation.github.io icon indicating copy to clipboard operation
react-navigation.github.io copied to clipboard

Add missing onSearchButtonPress option to native-stack-navigator.md

Open kellycampbell opened this issue 2 years ago • 1 comments

This important option was missing from the documentation. I found it in the underlying library's documentation at

https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md#screenstackheaderconfig

READ ME PLEASE

TL;DR: Make sure to add your changes to versioned docs

Thanks for opening a PR!

The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").

Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. /versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. :+1:

kellycampbell avatar May 01 '23 14:05 kellycampbell

Deploy Preview for react-navigation-docs ready!

Name Link
Latest commit fd0ba8ffc1285af29669c84960537db039193245
Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/644fccdb3910bb00075181e5
Deploy Preview https://deploy-preview-1238--react-navigation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar May 01 '23 14:05 netlify[bot]