react-navigation.github.io icon indicating copy to clipboard operation
react-navigation.github.io copied to clipboard

Update documentation to correct the default value of `labelVisible`

Open gkasdorf opened this issue 2 years ago • 1 comments

This is regarding this PR https://github.com/react-navigation/react-navigation/pull/11308. It was recommended to update the documentation, which I never got around to making a PR for.

The documentation currently states that labelVisible in HeaderBackButton defaults to true on iOS while false on Android, however that is not correct. On both platforms it defaults to false.

Regardless of what decision you make on that PR, I figure that it may as well be worth updating the 6.x documentation to state that it does not default to true. I'm not sure how prevalent iOS back buttons without a label are, but it may be best to just leave it be until 7.x if you were going to make the change, since there may be those who don't want the label and are just using the default value as of right now.

I've only updated 6.x since I am not sure what your stance will be going forward on the PR and if you would want to implement that into 7.x.

Thanks

gkasdorf avatar Apr 26 '23 07:04 gkasdorf

Deploy Preview for react-navigation-docs ready!

Name Link
Latest commit 8c20560a66d04a822624aa79ca9139f25db8afca
Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/6448cefb4eec0e0008fcd5c2
Deploy Preview https://deploy-preview-1237--react-navigation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Apr 26 '23 07:04 netlify[bot]