react-navigation.github.io icon indicating copy to clipboard operation
react-navigation.github.io copied to clipboard

update react-native-gesture-handler install doc

Open ramyareye opened this issue 3 years ago • 3 comments

ramyareye avatar Jul 16 '22 15:07 ramyareye

Deploy Preview for react-navigation-docs ready!

Name Link
Latest commit 0ef4328450b412bd812d316d02636842f6e95b39
Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/62d2d3285cb0ce0008f6bb58
Deploy Preview https://deploy-preview-1165--react-navigation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 16 '22 15:07 netlify[bot]

Hi @ramyareye :wave:

I don't this change is necessary as we wrap stack & drawer with GestureHandlerRootView internally in react-navigation eg. here.

Have you had problems with installing react-native-gesture-handler in react-navigation and wrapping your app with GestureHandlerRootView helped with?

Cheers

kacperkapusciak avatar Jul 19 '22 09:07 kacperkapusciak

Hi @ramyareye 👋

I don't this change is necessary as we wrap stack & drawer with GestureHandlerRootView internally in react-navigation eg. here.

Have you had problems with installing react-native-gesture-handler in react-navigation and wrapping your app with GestureHandlerRootView helped with?

Cheers

@kacperkapusciak there is a step to finalize react-native-gesture-handler installation in here and here which is outdated way to setup, either remove them or fix? Anyway I didn't read you have this GestureHandlerRootView under the hood anywhere :D

ramyareye avatar Jul 25 '22 04:07 ramyareye

Those steps are needed if you use gesture handler API in your project. For React Navigation, it already takes care of adding the root view whenever necessary and the consumer doesn't need to add them manually.

satya164 avatar Oct 31 '22 22:10 satya164